Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow alphabetical ordering of bookmarks on dashboard #16256

Closed
AliMickey opened this issue May 23, 2024 · 6 comments · Fixed by #16426
Closed

Allow alphabetical ordering of bookmarks on dashboard #16256

AliMickey opened this issue May 23, 2024 · 6 comments · Fixed by #16426
Assignees
Labels
complexity: low Requires minimal effort to implement type: feature Introduction of new functionality to the application

Comments

@AliMickey
Copy link

NetBox version

v4.0.2

Feature type

Change to existing functionality

Proposed functionality

Add additional order by options for bookmarks on the dashboard.

Use case

Alphabetical ordering is useful, and also matches the default table ordering of other sections.

Database changes

No response

External dependencies

No response

@AliMickey AliMickey added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels May 23, 2024
@jeremystretch
Copy link
Member

Add additional order by options for bookmarks on the dashboard.

Please expand on your proposal. How would bookmark ordering be specified? Are you asking that the widget itself be extended?

@jeremystretch jeremystretch added status: revisions needed This issue requires additional information to be actionable and removed status: needs triage This issue is awaiting triage by a maintainer labels May 23, 2024
@AliMickey
Copy link
Author

I didn't think I'd need to expand, sorry if I wasn't clear.

I am referencing the bookmarks widget on the dashboard, within which the configuration for it there is an 'Order by' field, the only two options are newest and oldest. I am suggesting that there be a third option called 'Alphabetical' which does what it means... sorts the bookmarks alphabetically.

image

@jeremystretch
Copy link
Member

Unfortunately alphabetical ordering is not feasible as there's no way to reliably and efficiently order by the name of generic related objects. (Not all objects have a name field.)

@AliMickey
Copy link
Author

Understood.

It wouldn't be clean, but still possible by just checking if each object has a name field, if yes add it to an array and sort alphabetically once loop is finished. Then append the non name objects to the end.

@jeremystretch
Copy link
Member

It could probably be done in memory on the string representations of each object, given that the list of bookmarks typically shouldn't be very long. I'll open this for any volunteers.

@jeremystretch jeremystretch removed their assignment May 28, 2024
@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation complexity: low Requires minimal effort to implement and removed status: revisions needed This issue requires additional information to be actionable labels May 28, 2024
@Julio-Oliveira-Encora
Copy link
Contributor

Could you please assign it to me?

@arthanson arthanson removed the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Jun 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
complexity: low Requires minimal effort to implement type: feature Introduction of new functionality to the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants