-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Infiniband interfaces #1941
Comments
Happy to provide feedback if you need it, though I'm not sure what I'm answering. |
Maybe it is possible to create a new database table for all interface types? so users can add their own interface types. We could also need MPO (https://en.wikipedia.org/wiki/Optical_fiber_connector) |
I'm not familiar with Infiniband myself, so a pull request adding the appropriate types to IFACE_FF_CHOICES would be greatly appreciated. |
This was brought up in IRC as the PR has been put through, and after reviewing some of the documentation, I think this issue should be changed from adding to the form factors to adding to the cable types. My read on Infiniband is that there are two common form factors: CXP & QSFP. The SDR/DDR/FDR/etc are all underlying protocols and cable configurations that are supported by those form factors. I think it would be a good idea to add "Infiniband" to the form factor list and then add the following form factors:
This follows the same vein as FibreChannel where there is a different procotol at work but they use the same form factors. Then, include the cables as the data rate definers for Infiniband with:
However, with the recent PR for DAC/AOC cables, we did not define speed there, so that may not be something we want to do with cables either. What is really needed to properly model this is a "module" section where you connect a module, and that module defines the datarate. My question would be, for someone with an Infiniband switch/device, how does the interface present if you are using a SDR/DDR/FDR etc. Is it defined in the name? If so, then we don't need to worry about the speeds at all. |
From #1865
I think this hits the nail on the head. Since the Infiniband interfaces aren't physical interfaces, they shouldn't be included in the list themselves. Instead, an Infiniband category and QSFP and CXP are the way forward IMO. |
Is there any further movement on this issue? The database / YAML file / whatever for defining our own interface types is still the fastest way to work around limitations in existing supported protocols, but at any rate, Infiniband is important and widely used, and we'd like to incorporate it as a use case. |
#2849 is open and awaiting feedback. Have you looked at it? |
It looks like it was already committed to develop? Any idea when that will be folded into the main release? Thanks! |
No, it is a pull request which is requesting permission to merge the change into develop. |
For everyone who claims they want to see this added, #2849 has been open for months with virtually no feedback. |
I do not need an InfiniBand myself, but I would very much like to be able to define my own interfaces:
|
NetBox only models network interfaces. |
I understand and accept the argumentation in #84, #97 and #1865. |
Which is why NetBox uses different models for each of these. The subject of this FR is Infiniband specifically; let's keep the conversation on-topic please. |
Infiniband is L2 networking, over which one can run IP, similar to how
Ethernet is l2 and you can run IP on it. That's not the native
method, but most of the interfaces we run IP on didn't start that way
either.
It's being used a lot in high performance compute environments, and since
people are deploying machine learning and big data
clusters a lot these days, its role in data centers will continue to
expand.
I can see why there's a perceived difference between IB and ethernet, in
the same way that people might think of it just as a replacement
for FiberChannel, but even FiberChannel is a networking technology which we
need to track in our data centers, in the same way
we're now tracking cables and patch panels, if nothing else.
|
Issue type
[x] Feature request
[ ] Bug report
[ ] Documentation
Environment
Description
Infiniband is a commonly used verbs communication protocol that is commonly used for high performance computing. Whilst adapters and connectors follow the same form factor as some ethernet, their available protocols are very different. Another factor is that a single form factor connector may support different protocols, and critically the DAC itself has specific protocol support too, so specifying what the protocol is supported on the NIC is critical.
Proposal:
Add all Infiniband interfaces as their protocols within their own category.
Reference:
https://en.wikipedia.org/wiki/InfiniBand
The text was updated successfully, but these errors were encountered: