Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Extreme Networks SummitStack as port types #2168

Closed
tradiuz opened this issue Jun 14, 2018 · 3 comments · Fixed by #2169
Closed

Add Extreme Networks SummitStack as port types #2168

tradiuz opened this issue Jun 14, 2018 · 3 comments · Fixed by #2169
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@tradiuz
Copy link
Contributor

tradiuz commented Jun 14, 2018

Issue type

[X] Feature request
[ ] Bug report
[ ] Documentation

Environment

  • Python version: 3.5.2
  • NetBox version: 2.3.5

Description

Adding support for Extreme stacking ports is fairly easy, just requires updating the constants.py to include the SummitStack, SummitStack128, and SummitStack512 port types under stacking.

@candlerb
Copy link
Contributor

I think it was unwise to have Cisco and Juniper stacking interfaces in the Netbox core, as this opens the door to every possible vendor's type of proprietary stacking port being requested.

A user-customisable table of interface types (similar to Device Type) would be the ideal solution. Then if you have (say) GPON interfaces, you can document those too.

In the absence of that, I'd suggest adding a generic "Other" under Stacking Port. That doesn't completely help people whose vendors have more than one port type, but there is already a free-form "Description" field that can say whether it's a type Foo or Bar.

@jeremystretch
Copy link
Member

My rule is that if it's a legitimately unique physical interface type in common usage, we'll add it. Sometimes "stacking" ports are really just standard Ethernet interfaces which have been designated for a specific function. Extreme appears to use a combination of standard and proprietary interfaces, so we can add the proprietary ones (taken from this data sheet):

  • SummitStack
  • SummitStack-128
  • SummitStack-256
  • SummitStack-512

@tradiuz
Copy link
Contributor Author

tradiuz commented Jun 15, 2018

I agree with @candlerb that having a table would be the ideal solution (this is how RackTables does it). That would give room for having server interconnects (SAS HBA -> Disk Shelf).
However, in the interim, I'd like to add support for the platform I spend all day on. I'll update my PR with SummitStack-256.

jeremystretch added a commit that referenced this issue Jun 29, 2018
Closes #2168: Add Extreme SummitStack interface form factors
jeremystretch added a commit that referenced this issue Jun 29, 2018
Revert "Closes #2168: Add Extreme SummitStack interface form factors"
@jeremystretch jeremystretch reopened this Jun 29, 2018
@jeremystretch jeremystretch added the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Jun 29, 2018
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Jul 18, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants