Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow filtering interfaces by type on device view #3090

Closed
jeremystretch opened this issue Apr 18, 2019 · 1 comment · Fixed by #3838
Closed

Allow filtering interfaces by type on device view #3090

jeremystretch opened this issue Apr 18, 2019 · 1 comment · Fixed by #3838
Labels
status: accepted This issue has been accepted for implementation

Comments

@jeremystretch
Copy link
Member

jeremystretch commented Apr 18, 2019 •
edited
Loading

Environment

  • Python version: 3.5.6
  • NetBox version: 2.5.10

Proposed Functionality

Add a dropdown menu at the top of the device interfaces tables (next to "show IPs") to allow filtering interfaces by form factor/type. We don't have any sufficient UI framework in place yet to do this dynamically, so for now we're looking at a full page refresh: A link to something like /dcim/devices/123/?interface_type=800. A search box with some jQuery to display only interfaces with a matching name should suffice.

Use Case

Some switches, especially large chassis switches, can have hundreds of interfaces. Sometimes a user may want to edit all interfaces of a certain type in bulk. Currently, this requires selecting each interface individually.

Database Changes

None

External Dependencies

None
@jeremystretch jeremystretch added status: under review Further discussion is needed to determine this issue's scope and/or implementation type: feature Introduction of new functionality to the application labels Apr 18, 2019
@mmahacek
Copy link
Contributor

Maybe also a filter for connected/not connected or enabled/disabled? I don't know that I see a benefit to having all fields filterable here. However, being able to sort by any column on the fly would be nice.
I would also suggest adding a count of interfaces to the table header, so users know how many are filtered out. Mock up images attached.

image
image

@jeremystretch jeremystretch added type: ui and removed type: feature Introduction of new functionality to the application labels May 2, 2019
@jeremystretch jeremystretch mentioned this issue May 10, 2019
Closed
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Dec 13, 2019
@hSaria hSaria mentioned this issue Jan 3, 2020
Merged
jeremystretch added a commit that referenced this issue Jan 9, 2020
@jeremystretch
Merge pull request #3838 from hSaria/3090-interface-filtering
959a0da 
Fixes #3090: Interface filtering
@jeremystretch jeremystretch mentioned this issue Jan 13, 2020
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: accepted This issue has been accepted for implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #3090: Interface filtering
2 participants
@jeremystretch @mmahacek