Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all instances of .extra() in QuerySets with annotations #3117

Closed
jeremystretch opened this issue Apr 27, 2019 · 2 comments
Closed

Replace all instances of .extra() in QuerySets with annotations #3117

jeremystretch opened this issue Apr 27, 2019 · 2 comments
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user

Comments

@jeremystretch
Copy link
Member

Proposed Changes

There are several instances where .extra() is used to extend a QuerySet. These should be replaced with .annotate() using RawSQL where necessary.

Justification

.extra() is planned for deprecation.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels Apr 27, 2019
@KhaledTo
Copy link

KhaledTo commented Jun 5, 2019 •
edited
Loading

Would like to have a look at this.

@chambersh1129 chambersh1129 mentioned this issue Sep 29, 2019
Merged
kobayashi added a commit that referenced this issue Oct 10, 2019
@kobayashi
Merge pull request #3553 from chambersh1129/develop
e223c88 
Replace all instances of .extra() in QuerySets with annotations #3117
@kobayashi
Copy link
Contributor

closed in e223c88

@lock lock bot locked as resolved and limited conversation to collaborators Jan 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kobayashi @jeremystretch @KhaledTo