Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pagination to Provider Detail View #3393

Closed
tyler-8 opened this issue Aug 5, 2019 · 4 comments · Fixed by #3875
Closed

Add Pagination to Provider Detail View #3393

tyler-8 opened this issue Aug 5, 2019 · 4 comments · Fixed by #3875
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@tyler-8
Copy link
Contributor

tyler-8 commented Aug 5, 2019

Environment

  • Python version: 3.6.8
  • NetBox version: 2.5.13

Proposed Functionality

Similar to #3314, the provider detail circuit listing would benefit from pagination when the object count is higher than a few hundred entries.

Edit: Same goes for IP Address detail page (Related and Duplicate IPs) (/ipam/ip-addresses/<id>/)

Use Case

When viewing Providers (e.g., /circuits/providers/att/) with a high number of circuits, the page loads very slow (and performs a larger DB query). Adding pagination will reduce the load on the webserver and the DB.

Edit: Same goes for IP Address detail page (Related and Duplicate IPs) (/ipam/ip-addresses/<id>/)

Database Changes

NA

External Dependencies

NA

@tyler-8
Copy link
Contributor Author

tyler-8 commented Aug 15, 2019

Title needs to be changed to reflect the IP address detail page to be covered in this too.

@tb-killa
Copy link
Contributor

I think in this framework a global pagination should be introduced for all possible tables that exist as APPS in Netbox.

@tyler-8
Copy link
Contributor Author

tyler-8 commented Aug 26, 2019

I think in this framework a global pagination should be introduced for all possible tables that exist as APPS in Netbox.

The project is already using https://github.com/jieter/django-tables2 to do just that - just needs to be enabled for the pages in question.

@shuichiro-makigaki
Copy link
Contributor

Regarding "Related IP Address" table in the IP Address view, it becomes too heavy to load when the related IP address list is big. It is because the table does not have pagination feature (all items are listed on one page even if the list size is >9999...).

I think it is challenging to enable pagination on the table only because it is implemented as one of the subpanels on this page. Moving to a separate tab is easier in terms of implementation.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application labels Oct 17, 2019
jeremystretch added a commit that referenced this issue Jan 9, 2020
Fixes #3393: Paginate circuits at the provider details view
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants