Message when disconnecting a cable not showing ID

[hSaria]

Environment

• Python version: 3.6.8
• NetBox version: 2.6.12-dev

Steps to Reproduce

1. Go to a device (e.g. dcim/devices/1/)
2. Disconnect a cable

Expected Behavior

The message says Deleted cable #5 where 5 is the ID of the cable.

Observed Behavior

The message says #None

This is similar to #2984

[phurrelmann]

Maybe it would even be better to display the label if it is given. This would mimic the behaviour as shown on the device/interface view where the cable id is only displayed when the cable has no label set.

[hSaria]

It already does. The issue is that self.id_string wasn't assigned prior to getting deleted. It's only the PK that gets nullified when deleted so the label is unaffected by this issue.

netbox/netbox/dcim/models.py

Lines 3030 to 3038 in b7e7802

	def __str__(self):
	if self.label:
	return self.label
	# Save a copy of the PK on the instance since it's nullified if .delete() is called
	if not hasattr(self, 'id_string'):
	self.id_string = '#{}'.format(self.pk)
	return self.id_string

[phurrelmann]

perfect, then I misunderstood your comment. Sorry and thank you for your impressive work on old tickets over he last days 👍

[hSaria]

Nothing to be sorry for. In fact, I appreciate you looking out, so thanks for that and keep it coming. And I'm just giving back some love to this project that clearly deserves it.