Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status tab claims device is inactive #3960

Closed
lukasjuhrich opened this issue Jan 20, 2020 · 1 comment · Fixed by #3969
Closed

Status tab claims device is inactive #3960

lukasjuhrich opened this issue Jan 20, 2020 · 1 comment · Fixed by #3969
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@lukasjuhrich
Copy link

Environment

  • Python version: 3.7.6
  • NetBox version: 2.7.1

Steps to Reproduce

  1. Have DCIM devices which are active (in the sense of the dcim_device.status column in the database) and have a valid database navigation
  2. Navigate to the device overview

Expected Behavior

The status tab should be enabled and clickable.

Observed Behavior

The status tab is not clickable, instead it reports device must be in active status.
However, manually navigating to status/ works perfectly fine and displays all desired data.

Probable reason

The template still checks device.status == 1 using the legacy numerical value (although this might be plain wrong because I don't know the codebase).
@kobayashi kobayashi added the type: bug A confirmed report of unexpected behavior in the application label Jan 21, 2020
@kobayashi
Copy link
Contributor

Confirmed and accepted this as bug.

@kobayashi kobayashi mentioned this issue Jan 21, 2020
Merged
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Jan 21, 2020
jeremystretch added a commit that referenced this issue Jan 21, 2020
@jeremystretch
Merge pull request #3969 from kobayashi/3960-legacy-device-status
856d14a 
Fixes: #3960 legacy device status
@jeremystretch jeremystretch mentioned this issue Jan 21, 2020
Merged
@hSaria hSaria mentioned this issue Feb 7, 2020
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes: #3960 legacy device status kobayashi/netbox
3 participants
@kobayashi @lukasjuhrich @jeremystretch