Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG rack elevations: devices should have borders separating them #3964

Closed
hellerve opened this issue Jan 20, 2020 · 5 comments · Fixed by #3972
Closed

SVG rack elevations: devices should have borders separating them #3964

hellerve opened this issue Jan 20, 2020 · 5 comments · Fixed by #3972
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@hellerve
Copy link
Contributor

Environment

  • Python version:
  • NetBox version:

Quoting from #3958:

For devices which are butted together and have the same role/colour, there is no longer any line separating them - see example below. This comprises two 2U boxes and a 4U box, but is now very hard to see.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application labels Jan 21, 2020
jeremystretch added a commit that referenced this issue Jan 21, 2020
@candlerb
Copy link
Contributor

This is much better, thank you. There's just one minor point remaining.

When full-depth devices are mounted at the front of the rack, and I view from the front, then I see the borders as expected. But I don't see the borders when viewing from the rear:

image

I'm not 100% sure that they had borders in the old HTML version, but I thought they did. It would be a "nice to have".

@hellerve
Copy link
Contributor Author

I didn’t touch the rear part. It shouldn’t be a problem to add (basically the same change that I did for the front); if we get buy-in from @jeremystretch I’ll add it tomorrow.

@hellerve
Copy link
Contributor Author

Maybe we should open a new issue for this?

@DanSheps
Copy link
Member

You can open a new issue, I can approve it for you right away if you want to start on the PR

@hellerve
Copy link
Contributor Author

Thanke @DanSheps, I just opened #4019. I’ll first be able to fix it tomorrow, though, since it’s getting pretty late over here in Europe! :)

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants