Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter or highlight devices in rack elevation based on device attributes #4434

Closed
ryanmerolle opened this issue Apr 1, 2020 · 8 comments
Closed
Assignees
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone

Comments

@ryanmerolle
Copy link
Contributor

Environment

  • Python version: 2.6.9
  • NetBox version: 2.7.11

Proposed Functionality

Allow a device filter or highlight (ie fade devices not matching criteria) option in rack elevations based on device attributes like tag, platform, device type, manufacturer.

Use Case

This would be useful to view your racks and provide easier visibility of where devices of a similar attribute are physically racked.

Database Changes

N/A more of a front end tweak.

External Dependencies

N/A

@ryanmerolle
Copy link
Contributor Author

Not a major request, and I understand if you think its not worth the effort. I just had a user who wanted to see where exactly all devices of a particular tag were racked. Currently, there is no easy way to view this all in the rack elevations view.

@jeremystretch
Copy link
Member

I don't think we'd be able to use the filtersets for this, so it would need some new mechanism for indicating which devices to highlight. It's probably too much to ask for in the API natively at this point, and better suited to implementation directly within the UI. (For example, to highlight all device elements with foo in their data-tags property.)

I could see a partial implementation where we pass device IDs in the form ?render=svg&highlight=123&highlight=456. This could be useful for providing a "view in rack" link for individual devices (or in the case of virtual chassis, multiple devices).

@jeremystretch jeremystretch added the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Apr 1, 2020
@ryanmerolle
Copy link
Contributor Author

That does not sound like a bad approach at all.

@jeremystretch jeremystretch changed the title Filter or highlight devices in rack elevation based on device attrbitutes Filter or highlight devices in rack elevation based on device attributes Apr 6, 2020
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Apr 23, 2020
@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed status: accepted This issue has been accepted for implementation labels Jul 24, 2020
@stale
Copy link

stale bot commented Sep 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Please see our contributing guide.

@stale stale bot added the pending closure Requires immediate attention to avoid being closed for inactivity label Sep 7, 2020
@jeremystretch jeremystretch added needs milestone Awaiting prioritization for inclusion with a future NetBox release and removed pending closure Requires immediate attention to avoid being closed for inactivity status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Sep 14, 2020
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed needs milestone Awaiting prioritization for inclusion with a future NetBox release labels May 25, 2021
@jeremystretch jeremystretch added this to the v3.2 milestone May 25, 2021
@dpotter-intoto
Copy link

Please consider including device status when implementing this feature... how great would it be to generate a rack elevation that highlights all devices with the planned status or the decommissioning status?

@ekrichbaum
Copy link

To avoid messing with the display of the rack elements themselves, set the color of the RU number background. I was originally thinking based on the role color and then having a role for deprecated, but assigning colors to the states of the device would work as well.

image

@jeremystretch
Copy link
Member

Per #9035 we should also support highlighting rack reservations.

@ITJamie
Copy link
Contributor

ITJamie commented May 26, 2022

I don't think we'd be able to use the filtersets for this, so it would need some new mechanism for indicating which devices to highlight. It's probably too much to ask for in the API natively at this point, and better suited to implementation directly within the UI. (For example, to highlight all device elements with foo in their data-tags property.)

I could see a partial implementation where we pass device IDs in the form ?render=svg&highlight=123&highlight=456. This could be useful for providing a "view in rack" link for individual devices (or in the case of virtual chassis, multiple devices).

It would be nice if you navigate to the rack page from a device page via the U position link for it to automatically highlight the device on the rack view.

jeremystretch added a commit that referenced this issue Jun 24, 2022
…ights

Closes #4434: Enable highlighting devices within rack elevations
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

5 participants