-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert device/VM component templates to tables #4786
Comments
Would this be a good time to look at something like datatables for this? |
I opened this primarily as a reminder to myself, but recall that #4193 was opened a while back and as you mention datatables was suggested. However, that was before we introduced the ability to toggle and order table columns. I'm not necessarily opposed to implementing datatables, but I'd prefer to avoid the dependency and UI overhead if we can. I also don't want to risk putting too much effort into a frontend component that will potentially be replaced in a v3.0 world anyway. It should be fairly straightforward to convert the existing templates to Table objects. Let me dig into it a bit more and if it seems to be a reasonable amount of effort for a few quick wins (enumerated above) I'd be happy with that for now. |
@jeremystretch please assign to me |
@whitej6 Are you sure? This is going to be fairly involved: each of the device component tables employed under the component list views (e.g. As we're getting ready to make the jump to v2.9, these changes will need to be made against the |
@whitej6 Can you share what progress you've made on this? |
…tables #4786: Convert device component templates to tables
Proposed Changes
When viewing a device, its associated components (console ports, power outlets, interfaces, etc.) are displayed in tables, however each row is rendered using a static template (e.g.
dcim/inc/interface.html
). The same goes for virtual machine interfaces. This issue proposes replacing these static templates with Table objects, similar to how the global component lists are rendered.Justification
This change would have several benefits:
The text was updated successfully, but these errors were encountered: