Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize on mechanism for specifying generic related objects during CSV import #5306

Closed
jeremystretch opened this issue Nov 3, 2020 · 0 comments
Closed

Standardize on mechanism for specifying generic related objects during CSV import #5306

jeremystretch opened this issue Nov 3, 2020 · 0 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user

Comments

@jeremystretch
Copy link
Member

jeremystretch commented Nov 3, 2020 •
edited
Loading

Proposed Changes

When importing objects in CSV format, require specifying the related object type in the form <app>.<model> for consistency. The following forms need to be updated:

  • CableCSVForm: Import A/B terminations using model name only
  • IPAddressCSVForm: assigned_object_type does not use CSVModelChoiceField
  • SecretCSVForm: Object type uses model name only

Justification

Ensures a consistent UX for importing all types of objects.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels Nov 3, 2020
@jeremystretch jeremystretch self-assigned this Nov 17, 2020
jeremystretch added a commit that referenced this issue Dec 1, 2020
@jeremystretch
#5306: Introduce CSVContentTypeField for cable termination types
cadba74
jeremystretch added a commit that referenced this issue Dec 2, 2020
@jeremystretch
#5306: Standardize device/VM assignment for IP addresses & secrets
f504d1a
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeremystretch