Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect raw value for "loose" custom field filter logic #5376

Closed
jeremystretch opened this issue Nov 24, 2020 · 0 comments
Closed

Incorrect raw value for "loose" custom field filter logic #5376

jeremystretch opened this issue Nov 24, 2020 · 0 comments
Assignees
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@jeremystretch
Copy link
Member

Environment

  • Python version: 3.6.9
  • NetBox version: 2.9.9

Steps to Reproduce

  1. Create a custom field with its filter logic set to "loose"
  2. Inspect the column's value in the database table (extras_customfield.filter_logic)

Expected Behavior

The value should read "loose".

Observed Behavior

The value reads "integer".

This is due to an error in database migration 0029_3569_customfield_fields under the extras app, which incorrectly converts the old numeric representation to the slug value "integer" instead of "loose". (This was due to a copy/paste error when constructing the migration.)

It's worth noting that this error doesn't actually inhibit functionality. However, with REST API support being introduced for custom fields in v2.10 (#5274), the value needs to be corrected.

@jeremystretch jeremystretch added type: bug A confirmed report of unexpected behavior in the application status: accepted This issue has been accepted for implementation labels Nov 24, 2020
@jeremystretch jeremystretch self-assigned this Nov 24, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

No branches or pull requests

1 participant