Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtual Machine Interfaces table should be moved to separate tab #6014

Closed
cpmills1975 opened this issue Mar 19, 2021 · 4 comments
Closed

Virtual Machine Interfaces table should be moved to separate tab #6014

cpmills1975 opened this issue Mar 19, 2021 · 4 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v2.11

Comments

@cpmills1975
Copy link
Contributor

cpmills1975 commented Mar 19, 2021 •
edited
Loading

NetBox version

v2.10.7

Feature type

Change to existing functionality

Proposed functionality

All of the component tables on Devices have moved from the device page to separate tabs. I'm proposing that the Interfaces table for Virtual Machines also becomes its own tab to mimic the Device page.

Use case

While most users probably aren't dealing with huge lists of interfaces on Virtual Machines, the UX should be as consistent as possible between Devices and Virtual Machines.

Database changes

None

External dependencies

None
@cpmills1975 cpmills1975 added the type: feature Introduction of new functionality to the application label Mar 19, 2021
@jeremystretch
Copy link
Member

I agree, however the UI is currently in flux pending the v2.12 work. Going to mark this as blocked for now and tag it for v2.12.

@jeremystretch jeremystretch added the status: blocked Another issue or external requirement is preventing implementation label Mar 24, 2021
@jeremystretch jeremystretch added this to the v2.12 milestone Mar 24, 2021
@cpmills1975
Copy link
Contributor Author

As soon as there is a clone-able version with the UI improvements in it, I'd been keen to take it for a spin in my dev environment. Is this likely to be on the devel branch after the release of 2.11 or are you thinking of running a separate branch for the UI changes?

@jeremystretch jeremystretch removed this from the v2.12 milestone Mar 26, 2021
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: blocked Another issue or external requirement is preventing implementation labels Mar 26, 2021
@jeremystretch jeremystretch self-assigned this Mar 26, 2021
@jeremystretch
Copy link
Member

We decided to push the UI overhaul to v2.12, so I'm going to knock this out shortly.

@jeremystretch jeremystretch added type: housekeeping Changes to the application which do not directly impact the end user and removed type: feature Introduction of new functionality to the application labels Mar 27, 2021
@jeremystretch jeremystretch added this to the v2.11 milestone Mar 27, 2021
@jeremystretch
Copy link
Member

Fixing this under v2.11 since we've tweaked the generic templates a good bit already.

jeremystretch added a commit that referenced this issue Mar 27, 2021
@jeremystretch
Closes #6014: Move virtual machine interfaces list to a separate view
0364d8c
@jeremystretch jeremystretch mentioned this issue Apr 16, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
v2.11
Development

No branches or pull requests
2 participants
@cpmills1975 @jeremystretch