Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devices: Add ability to filter by location including nested locations #6124

Closed
dreng opened this issue Apr 8, 2021 · 3 comments
Closed

Devices: Add ability to filter by location including nested locations #6124

dreng opened this issue Apr 8, 2021 · 3 comments
Assignees
Labels
beta Concerns a bug/feature in a beta release status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@dreng
Copy link
Contributor

dreng commented Apr 8, 2021

NetBox version

v2.11.0-dev

Feature type

New functionality

Proposed functionality

On the devices page it is possible to filter by locations already. It would be very handy to have the ability to select a location with an additional checkbox "Include children", preferably initially checked. If the checkbox is checked every device in the chosen location and every device in all locations that are children of the chosen location should be shown.

Use case

Let's assume you have many nested locations (e.g. 5 floors, containing 20 rooms each). In order to get an overview of all devices belonging to a floor and all the rooms it contains you have to choose 21 locations in the filter pane.

In contrast it's necessary to choose just one location (and probably a checkbox) with this feature.

Database changes

none

External dependencies

none

@dreng dreng added the type: feature Introduction of new functionality to the application label Apr 8, 2021
@jeremystretch
Copy link
Member

In order to get an overview of all devices belonging to a floor and all the rooms it contains you have to choose 21 locations in the filter pane.

The location filter (like the filters for region, site group, etc.) is hierarchical in nature: You only need to select the floor, and it will match all devices assigned to either the floor or to a location within the floor.

@jeremystretch jeremystretch added the pending closure Requires immediate attention to avoid being closed for inactivity label Apr 9, 2021
@dreng
Copy link
Contributor Author

dreng commented Apr 9, 2021

I'm sorry, but I would have sworn that I have tested exactly that scenario and got another result. I have to admit that you're right.

Probably I had the locations view in mind. If you go to locations and select e.g. Floor 1 then only devices belonging to exactly that location are being listed. That might be intended. I'd prefer a resursive view.

@stale stale bot removed the pending closure Requires immediate attention to avoid being closed for inactivity label Apr 9, 2021
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application beta Concerns a bug/feature in a beta release and removed type: feature Introduction of new functionality to the application labels Apr 11, 2021
@jeremystretch jeremystretch self-assigned this Apr 11, 2021
jeremystretch added a commit that referenced this issue Apr 11, 2021
@dreng
Copy link
Contributor Author

dreng commented Apr 12, 2021

I'm not sure if we misunderstood each other but this seems to be not implemented in the current feature branch.

See this:
2021-04-12 10_36_44-Window

But that:
2021-04-12 10_38_00-Window

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beta Concerns a bug/feature in a beta release status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

No branches or pull requests

2 participants