Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ESLint, TypeScript to mutually supported versions & fix Sass deprecation warning #7066

Closed
thatmattlove opened this issue Aug 30, 2021 · 0 comments
Closed

Update ESLint, TypeScript to mutually supported versions & fix Sass deprecation warning #7066

thatmattlove opened this issue Aug 30, 2021 · 0 comments
Assignees
@thatmattlove
Labels
type: housekeeping Changes to the application which do not directly impact the end user

Comments

@thatmattlove
Copy link
Contributor

Proposed Changes

  • Update ESLint and/or TypeScript to mutually supported versions
  • Remove usage of / for division in Sass files

Justification

Will fix the following errors when running UI bundles:

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <4.4.0

YOUR TYPESCRIPT VERSION: 4.4.2

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.
@thatmattlove thatmattlove added the type: housekeeping Changes to the application which do not directly impact the end user label Aug 30, 2021
@thatmattlove thatmattlove self-assigned this Aug 30, 2021
thatmattlove added a commit that referenced this issue Aug 30, 2021
@thatmattlove
Fixes #7066: Migrate division statements in Sass from / to math.div
deda169
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@thatmattlove thatmattlove

Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thatmattlove