Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include circuit terminations when importing new circuits #815

Closed
patrickfish opened this issue Jan 19, 2017 · 4 comments
Closed

Include circuit terminations when importing new circuits #815

patrickfish opened this issue Jan 19, 2017 · 4 comments
Assignees
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone

Comments

@patrickfish
Copy link

When adding or editing a circuit, there is no longer a field for Site. Previous to ~1.8.2 you could select the Site that the circuit was associated with.

I do see that I can edit the terminations of the circuit once it's created, but we don't always have a termination point when adding the circuit for the first time.

Is this intended behavior or a bug?

@jeremystretch
Copy link
Member

v1.8.0 introduced the concept of circuit terminations, of which each circuit can have up to two. You'll need to first create the desired circuit, and then add terminations (either to a site or to a specific device within that site) separately.

I realize this isn't the most intuitive workflow. It may be workable to combine the creation of a circuit and its first termination in the same form, but I haven't yet looked into it.

@patrickfish
Copy link
Author

Ok - that makes sense from what I'm seeing then.

I add circuits as we get the turn-up information from the carrier, which is often before active equipment arrives. It's would be nice to have it tied to a specific site at this point.

Same goes for importing circuits as I see Site is no longer a field there. If I import 100 circuits, they're now somewhat orphaned because I have no other metadata that tells me what site it belongs to. Other circuits don't ever get a termination (ie broadband circuit to a SOHO router) but we still want to have a list of circuits per site.

@patrickfish patrickfish changed the title Unable to associate circuits to a site Unable to associate circuits to a site at creation/import Jan 19, 2017
@jeremystretch jeremystretch added the type: feature Introduction of new functionality to the application label Jan 23, 2017
@jeremystretch jeremystretch changed the title Unable to associate circuits to a site at creation/import Include circuit terminations when importing new circuits Jan 23, 2017
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Jan 26, 2018
@jeremystretch jeremystretch added status: under review Further discussion is needed to determine this issue's scope and/or implementation and removed status: accepted This issue has been accepted for implementation labels Jul 24, 2020
@jeremystretch
Copy link
Member

This is going to be fairly difficult to implement given the current model for circuit terminations, but it's up for grabs if anyone wants to dig into it.

@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Jul 24, 2020
@jeremystretch
Copy link
Member

This is almost certainly going to be much easier to accomplish once #4347 has added JSON/YAML-based import for all objects. Marking this as blocked pending that work.

@jeremystretch jeremystretch added status: blocked Another issue or external requirement is preventing implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Aug 14, 2020
@jeremystretch jeremystretch added needs milestone Awaiting prioritization for inclusion with a future NetBox release and removed status: blocked Another issue or external requirement is preventing implementation labels Nov 11, 2022
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed needs milestone Awaiting prioritization for inclusion with a future NetBox release labels Nov 18, 2022
@jeremystretch jeremystretch self-assigned this Nov 18, 2022
@jeremystretch jeremystretch added this to the v3.4 milestone Nov 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

2 participants