Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search bar contents not retained after submitting #8813

Closed
chonty opened this issue Mar 7, 2022 · 2 comments · Fixed by #8907
Closed

Search bar contents not retained after submitting #8813

chonty opened this issue Mar 7, 2022 · 2 comments · Fixed by #8907
Assignees
@PieterL75
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@chonty
Copy link

chonty commented Mar 7, 2022

NetBox version

v3.1.8

Python version

3.8

Steps to Reproduce

  1. Enter a search term into the main search bar and submit
  2. See empty search bar

Expected Behavior

  1. Enter a search term into the main search bar and submit
  2. Search term should still be present

Observed Behavior

  1. Enter a search term into the main search bar and submit
  2. Search bar is empty
@chonty chonty added the type: bug A confirmed report of unexpected behavior in the application label Mar 7, 2022
@PieterL75
Copy link
Contributor

PieterL75 commented Mar 10, 2022 •
edited
Loading

I've been wanting to submit a FR for this, but always forgot about it :-)
Maybe a good one to combine with #7839 (set input focus on searchbar )

@PieterL75 PieterL75 mentioned this issue Mar 14, 2022
Closed
@PieterL75
Copy link
Contributor

I have a PR for this ready.. @jeremystretch can you assign this to me ?

@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Mar 17, 2022
PieterL75 pushed a commit to PieterL75/netbox that referenced this issue Mar 17, 2022
update releasenotes netbox-community#7839,netbox-community#8813
d53d348
@PieterL75 PieterL75 mentioned this issue Mar 17, 2022
Closed
PieterL75 pushed a commit to PieterL75/netbox that referenced this issue Mar 18, 2022
Fixes netbox-community#8813 Retain search value after submitting
055c67f
@PieterL75 PieterL75 mentioned this issue Mar 18, 2022
Merged
jeremystretch pushed a commit that referenced this issue Mar 18, 2022
@PieterL75
Fixes #8813 Retain search value after submitting (#8907)
0da0423 
* Fixes #8813 Retain search value after submitting

* remove autofocus from searchbar

Co-authored-by: Pieter Lambrecht <pieter.lambrecht@sentia.com>
jeremystretch added a commit that referenced this issue Mar 18, 2022
@jeremystretch
Changelog for #8813
f64987d
@jeremystretch jeremystretch mentioned this issue Mar 25, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@PieterL75 PieterL75

Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
3 participants
@jeremystretch @chonty @PieterL75