Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devices with Images on the rear side are not clickable in the rack view svg. #8952

Closed
991jo opened this issue Mar 24, 2022 · 1 comment · Fixed by #8953
Closed

Devices with Images on the rear side are not clickable in the rack view svg. #8952

991jo opened this issue Mar 24, 2022 · 1 comment · Fixed by #8953
Assignees
@991jo
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@991jo
Copy link
Contributor

991jo commented Mar 24, 2022

NetBox version

v3.1.9

Python version

3.9

Steps to Reproduce

  1. create a rack
  2. create a full-depth device type
  3. add front and read pictures to the device type
  4. create a device with the created device type in the rack
  5. look at the front and rear of the device in the SVG with images enabled.

Expected Behavior

Front as well as rear should have a link to the device, independently of whether images are shown or not.

Observed Behavior

Only the front can be clicked. When only labels are show the Link can be clicked.
@991jo 991jo added the type: bug A confirmed report of unexpected behavior in the application label Mar 24, 2022
@991jo
Copy link
Contributor Author

991jo commented Mar 24, 2022

This was introduced by me in #8592
#7150 (comment)

I will shortly open a PR to fix this.

991jo added a commit to 991jo/netbox that referenced this issue Mar 24, 2022
@991jo
Fixed netbox-community#8952: rack rear faces link not clickable
daed3f5
991jo added a commit to 991jo/netbox that referenced this issue Mar 24, 2022
@991jo
Fixed netbox-community#8952: rack rear faces link not clickable
6ceb78f
@991jo 991jo mentioned this issue Mar 24, 2022
Merged
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Mar 24, 2022
jeremystretch added a commit that referenced this issue Mar 24, 2022
@jeremystretch
Merge pull request #8953 from 991jo/fix-8952
124fc73 
Fixed #8952: rack rear faces link not clickable
@jeremystretch jeremystretch mentioned this issue Mar 25, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@991jo 991jo

Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed #8952: rack rear faces link not clickable 991jo/netbox
2 participants
@991jo @jeremystretch