Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy contact fields from provider model #9046

Closed
ryanmerolle opened this issue Apr 6, 2022 · 2 comments
Closed

Remove legacy contact fields from provider model #9046

ryanmerolle opened this issue Apr 6, 2022 · 2 comments
Assignees
@arthanson
Labels
status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Milestone
v3.4

Comments

@ryanmerolle
Copy link
Contributor

NetBox version

v3.2.0

Feature type

Change to existing functionality

Proposed functionality

Remove legacy contact fields from provider model:

  • Customer Portal
  • NOC Contact
  • Admin Contact

Use case

Currently there is the above contact text fields and a contact association field.

Database changes

Requires a migration to remove the contact fields from providers.

External dependencies

No response
@ryanmerolle ryanmerolle added the type: feature Introduction of new functionality to the application label Apr 6, 2022
@jeremystretch jeremystretch changed the title Remove legacy ASN from provider model Remove legacy contact fields from provider model Apr 6, 2022
@jeremystretch jeremystretch added type: deprecation Removal of existing functionality or behavior needs milestone Awaiting prioritization for inclusion with a future NetBox release and removed type: feature Introduction of new functionality to the application labels Apr 6, 2022
@jeremystretch
Copy link
Member

Blocked by #8234

@jeremystretch jeremystretch added status: blocked Another issue or external requirement is preventing implementation and removed needs milestone Awaiting prioritization for inclusion with a future NetBox release labels Apr 6, 2022
@jeremystretch jeremystretch mentioned this issue Apr 7, 2022
Closed
@jeremystretch jeremystretch added needs milestone Awaiting prioritization for inclusion with a future NetBox release and removed status: blocked Another issue or external requirement is preventing implementation labels Apr 7, 2022
@jeremystretch
Copy link
Member

Disregard; #8234 has already been addressed.

@jeremystretch jeremystretch added this to the v3.4 milestone Jun 2, 2022
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed needs milestone Awaiting prioritization for inclusion with a future NetBox release labels Jun 2, 2022
@arthanson arthanson self-assigned this Sep 15, 2022
@arthanson arthanson mentioned this issue Sep 15, 2022
Merged
jeremystretch added a commit that referenced this issue Sep 28, 2022
@arthanson @jeremystretch
#9045 #9046 - remove legacy fields from Provider (#10377)
20e3fdc 
* #9045 - remove legacy fields from Provider

* Add safegaurd for legacy data to migration

* 9045 remove fields from forms and tables

* Update unrelated tests to use ASN model instead of Provider

* Fix migrations collision

Co-authored-by: jeremystretch <jstretch@ns1.com>
jeremystretch added a commit that referenced this issue Sep 28, 2022
@jeremystretch
Changelog for #9045, #9046, #9071
d486fa8
jsenecal pushed a commit to jsenecal/netbox that referenced this issue Sep 28, 2022
@arthanson @jeremystretch @jsenecal
netbox-community#9045 netbox-community#9046 - remove legacy fields fr…
ccb14be 
…om Provider (netbox-community#10377)

* netbox-community#9045 - remove legacy fields from Provider

* Add safegaurd for legacy data to migration

* 9045 remove fields from forms and tables

* Update unrelated tests to use ASN model instead of Provider

* Fix migrations collision

Co-authored-by: jeremystretch <jstretch@ns1.com>
jsenecal pushed a commit to jsenecal/netbox that referenced this issue Sep 28, 2022
@jeremystretch @jsenecal
Changelog for netbox-community#9045, netbox-community#9046, netbox-co…
945b83e 
…mmunity#9071
@jeremystretch jeremystretch mentioned this issue Dec 14, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@arthanson arthanson

Labels
status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Projects
None yet
Milestone
v3.4
Development

No branches or pull requests
3 participants
@arthanson @ryanmerolle @jeremystretch