Closes #11592: Expose FILE_UPLOAD_MAX_MEMORY_SIZE as a setting #11742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I create a commented out example in configuration_example.py? |
|
@aronbj20 yes, and please also add a short definition of the parameter in the configuration docs. |
|
Will do! |
|
@jeremystretch hope this is okay, english is not my native language. Please let me know if there is any additional changes required. |
|
Great, thank you @aronbj20! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11592
Exposes FILE_UPLOAD_MAX_MEMORY_SIZE as a setting so that it can be changed in configuration.py.
This addresses an issue where file uploads fails if file size is greater than django default value. With these changes a user will be able to increase the max file upload size to fit there need. I tested this and can confirm that these changes fixes netbox docker issue 897 by allowing the user to increase the max size.