Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #11473 graphql invalid tag filter returns all devices/interfaces #11755

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Fixes #11473 graphql invalid tag filter returns all devices/interfaces #11755

merged 2 commits into from
Feb 16, 2023

Conversation

aronbergurj99
Copy link
Contributor

Fixes: #11473

Return an empty queryset if the filterset is invalid in the static method ObjectListField.list_resolver().

@jeremystretch jeremystretch merged commit eee1a0e into netbox-community:develop Feb 16, 2023
@jeremystretch
Copy link
Member

Thanks @aronbj20!

@aronbergurj99 aronbergurj99 deleted the 11473-graphql-filter-fix branch March 11, 2023 11:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GraphQL returns all objects if tag doesn't exist
3 participants
@aronbergurj99 @jeremystretch @aronminn