12589 move user and group admin from admin #12877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12589
Moves user, groups and permissions pages from admin to NetBox UI.
Removed some bulk editing / bulk import as it didn't make sense or was a potential security issue. For example, the only thing you can set on a group is a name so it doesn't make sense to have bulk editing for it. Also didn't think we wanted to do bulk import for users as that would need a file with passwords in it.
Had to change some tests as the permission opt-out was special case to always apply for the user and group objects.
These have permission checks but wondering if we want to make some of them superuser only (ObjectPermission, Change Password, Edit User)? Will probably want some tweaks after discussing, but all the core functionality is there.