-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes: #11079 - Handle cables across multiple rear-port positions #13337
Conversation
Not sure how I feel about the logging, could definitely remove it or modify it if someone has strong opinions. |
This comment was marked as outdated.
This comment was marked as outdated.
Don't create the path. It would fail normally anyways, this just allows the cable to be created but not create the cable path. |
This is not a sufficient means of addressing the underlying issue. The assertions function as sanity checks: If they are being violated, we need to determine why and resolve accordingly. This might entail removing the assertions, or implementing other logic to accommodate the unexpected case. But merely logging them and avoiding creating the cable path is not a solution. |
I am moving to a bit of a rewrite to properly account for at least this type of cable path. It should be ready for re-review in a few days. |
This comment was marked as outdated.
This comment was marked as outdated.
I think this is ready @jeremystretch |
Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>
Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>
I have some fine-tuning to do on a new SVG rendering and then I will push that code as well. |
Things to note:
|
…' into 11079-Cablepath_catch_assertions # Conflicts: # netbox/dcim/tests/test_cablepaths.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been a huge undertaking. Thanks for seeing it through @DanSheps!
Fixes: #11079 - Add supported path through modules and multiple rear-ports with different positions on same device