Attached a clonable field multi selection, bug fixes #13935
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhi1693
reviewed
Sep 29, 2023
| @@ -43,7 +43,7 @@ def get_bound_field(self, form, field_name): | |||
|
|
|||
| if data is not None: | |||
| self.choices = [ | |||
| choice for choice in self.choices if choice[0] in data | |||
| choice for choice in self.choices if isinstance(self.choices, str) if choice[0] in data | |||
There was a problem hiding this comment.
Suggested change
| choice for choice in self.choices if isinstance(self.choices, str) if choice[0] in data | |
| choice for choice in self.choices if isinstance(self.choices, str) and choice[0] in data |
I think and should suffice here
jeremystretch
requested changes
Oct 3, 2023
|
@yash-pal1 are you still interested in working on this? |
trying to fix this, so sorry for not active on this issue |
|
Closing for inactivity. Please see #14612 for a (very similar) alternative fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13909