Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14044 handle bulk rename if None name #14065

Closed
wants to merge 2 commits into from
Closed

Conversation

arthanson
Copy link
Collaborator

Fixes: #14044

Checks if name empty for bulk_rename - put at top of procedure as there is a bug (beyond the issue) where if you use regex you get '' (instead of None) for the name which can cause postgres duplicate error if in the same site.

@arthanson arthanson marked this pull request as ready for review October 17, 2023 23:48
obj.new_name = obj.name.replace(find, replace)
else:
obj.new_name = obj.name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This effectively bypasses the rename operation, which may be sufficient, however #14044 seems to expect that unnamed devices would be renamed.

@arthanson arthanson closed this Dec 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2024
@arthanson arthanson deleted the 14044-bulk-rename branch April 18, 2024 15:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoneType AttributeError when Bulk Renaming Nameless Devices
2 participants