Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #14311: Move L2VPN models from ipam to vpn #14358

Merged
merged 4 commits into from
Nov 28, 2023

Conversation

jeremystretch
Copy link
Member

@jeremystretch jeremystretch commented Nov 27, 2023

Closes: #14311

Relocates the L2VPN and L2VPNTermination models, as well as all their related resources, from the ipam app to the new vpn app introduced by #9816.

@jeremystretch jeremystretch marked this pull request as draft November 27, 2023 21:51
@jeremystretch jeremystretch added this to the v3.7 milestone Nov 27, 2023
@jeremystretch jeremystretch marked this pull request as ready for review November 28, 2023 12:59
@DanSheps
Copy link
Member

DanSheps commented Nov 28, 2023

~~Testing this out, I am getting an integrity error after upgrading when trying to add a new termination to the L2VPN.

Will have more information shortly.~~

Edit: I must have been doing something wrong when testing, not able to reproduce.

Copy link
Member

@DanSheps DanSheps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed code, code looks to be in order with no references missing.

Tested locally, no issues with migrations or operations.

@jeremystretch jeremystretch merged commit d2fea4e into feature Nov 28, 2023
8 checks passed
@jeremystretch jeremystretch deleted the 14311-move-l2vpn branch November 28, 2023 18:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants