10587 script pagination #15343
Merged
10587 script pagination #15343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10587
Makes the script logs use a tables2 table which allows pagination and sorting of columns. There were a couple bugs in the scripts migrations which this fixes (was causing jobs not to get correctly mapped from old script/report runs).
Original FR asked for filtering and export, however the logs are stored as a dict and filtering requires a queryset so filtering is not possible without converting the individual logs lines to be stored as regular DB objects.
Table configuration is implemented but not tested as table configuration is currently broken across all views.