#15548 - False Positive Related Object in Custom Fields

[Julio-Oliveira-Encora]

Fixes: #15548

I created the class CustomObjectDeleteView, which was inherited from ObjectDeleteView, and overwritten the "get" method and its dependent_objects variable. This way, the modal from delete_form.html will not display messages about dependent objects.

Also, I changed the inherited class for CustomFieldDeleteView to use generic.CustomObjectDeleteView.

[jeremystretch]

Thanks for tackling this @Julio-Oliveira-Encora. I think there are a few issues with this approach.

First, we shouldn't need to introduce a custom class: ObjectDeleteView already has a _get_dependent_objects() method which we can override if needed to tweak which objects are returned.

Second, we can't blindly assume that no dependent objects will exist. The bug pertains only to the custom field's association with content types; it's very likely that other dependencies may exist now or in the future.

Finally, we want to consider whether the reported behavior affects other models in NetBox too. For instance, should we also ignore content type associations when deleting a custom link or export template? Probably. We might even want to ignore many-to-many associations entirely, as the deletion of these associations doesn't actually impact the related objects.

[jeremystretch]

I've proposed an alternative solution to this in #15889, which addresses the root issue more generally.