Fixes 15652 - PROTECTION_RULES: Custom Validator does not show error message on object deletion #15724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…return_url(request))". The toast is displayed with the message if the IP Address is protected.
…rl(request))". The toast is displayed with the message if the IP Address is protected.
jeremystretch
requested changes
Apr 15, 2024
There was a problem hiding this comment.
@Julio-Oliveira-Encora this change does not appear to address the bug. The returned URL is correct.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15652
The issue was solved by replacing the line 433 of "netbox/netbox/views/generic/object_views.py" with "return redirect(self.get_return_url(request))".
Please let me know if I should also replace line 428 of the same file.