Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15809 Mark unions as nullable in GraphQL where appropriate #15824

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

arthanson
Copy link
Collaborator

@arthanson arthanson commented Apr 23, 2024

Fixes: #15809

Several of the GraphQL typing for Unions were missing | None to mark that they could return null values. Fixes the test suite as this change was causing them to incorrectly query if the union was optional.

@arthanson arthanson changed the title 15809 Mark unions as nullable in GraphQL where appropriate DRAFT: 15809 Mark unions as nullable in GraphQL where appropriate Apr 23, 2024
@arthanson arthanson marked this pull request as ready for review April 23, 2024 18:20
@arthanson arthanson requested a review from jeremystretch April 23, 2024 18:21
@arthanson arthanson changed the title DRAFT: 15809 Mark unions as nullable in GraphQL where appropriate 15809 Mark unions as nullable in GraphQL where appropriate Apr 23, 2024
@jeremystretch jeremystretch added the beta Concerns a bug/feature in a beta release label Apr 25, 2024
@jeremystretch jeremystretch merged commit ded2fe9 into feature Apr 25, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 15809-graphql-null branch April 25, 2024 13:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beta Concerns a bug/feature in a beta release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants