New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #15977: Hide all admin menu items for non-authenticated users #15978

Merged

jeremystretch merged 2 commits into develop from 15977-hide-admin-menu-items

May 7, 2024

Member

jeremystretch commented May 6, 2024

Fixes: #15977

Extend PluginMenuItem with auth_required boolean attribute & enforce when rendering the navigation menu
Set auth_required=True on all menu items under the admin group as a sanity check


          Fixes #15977: Hide all admin menu items for non-authenticated users

a4789ba

jeremystretch requested a review from arthanson

May 6, 2024 20:59


          Account for absence of auth_required on PluginMenuItem

5e86b8f

arthanson approved these changes

View reviewed changes

jeremystretch merged commit acc2add into develop

6 checks passed

jeremystretch deleted the 15977-hide-admin-menu-items branch

May 7, 2024 14:37

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet