Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

15973 fix switch type on cable edit #16049

Merged
merged 2 commits into from
May 9, 2024
Merged

15973 fix switch type on cable edit #16049

merged 2 commits into from
May 9, 2024

Conversation

arthanson
Copy link
Collaborator

@arthanson arthanson commented May 8, 2024 •
edited
Loading

Fixes: #15973

A couple difference scenarios were causing issues with different fixes (now working):

  1. Have a Circuit Termination and switch to a Console Port and have IDs of termination and console port matching - would leave Console Port field with value
  2. Was originally popping terminations above in the existing if a_type checks, but that caused a blank a_terminations if you add a cable from a device.

This also looks like it fixes #15783 and will also resolve #13278

@arthanson arthanson marked this pull request as ready for review May 8, 2024 21:50
@arthanson arthanson requested a review from jeremystretch May 8, 2024 21:51
@arthanson arthanson marked this pull request as draft May 8, 2024 22:04
@arthanson arthanson changed the title 15973 fix switch type on cable edit DRAFT: 15973 fix switch type on cable edit May 8, 2024
@arthanson arthanson changed the title DRAFT: 15973 fix switch type on cable edit 15973 fix switch type on cable edit May 9, 2024
@arthanson arthanson marked this pull request as ready for review May 9, 2024 16:11
@jeremystretch jeremystretch merged commit a953ff2 into develop May 9, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 15973-cable branch May 9, 2024 18:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeremystretch jeremystretch jeremystretch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@arthanson @jeremystretch