-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #15621: User notifications #16800
Conversation
Getting the following when checkout the code:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment on getting SystemCheckError wasn't able to actually run it to test.
Also, should add model docs for the new models?
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several crashes
There is no confirmation of delete on a notification. Not very critical if you delete it and you don't want, but everything else in NetBox has a confirmation on delete so not sure if this was by design. |
Yeah, I modeled it after GitHub notifications: Clicking through to an object will mark the notification as "read," but not delete it. Deletion is a manual task, but does not require confirmation, so that notifications can be easily dismissed. (I'm open to feedback about this during the beta, but suspect this approach will satisfy most users.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the icon to help convey each notification's urgency. We're currently using only info, but success, warning, and error are available as well. |
Closes: #15621
post_save
signal receiver to automatically generate notification for subscribed users