16670 fix OpenAPI schema generation with nested serializers #17078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthanson
changed the title
jeremystretch
requested changes
Aug 13, 2024
There was a problem hiding this comment.
This appears to incorrectly modify certain filters for related objects. For instance, the type for the region filter for circuits (which matches on a slug) is now reported as an integer rather than a string.
2510c2512,2513
< type: string
---
> type: integer
> description: Region (slug)
2518c2521,2522
< type: string
---
> type: integer
> description: Region (slug)
|
This looks like develop having a fix for the id -> string that wasn't merged into this PR. I merged in the latest develop and diff'd the .yaml files and they look correct from what I see. Also note when switching/checking you may need to remove the cache line here: https://github.com/netbox-community/netbox/blob/develop/netbox/netbox/urls.py#L60 |
jeremystretch
approved these changes
Aug 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16670
Adds 'Brief' to serializer name if it is called with nested=True, Adding 'Nested' conflicts with existing Nested Serializers, so went with Brief.