Fixes: #14044 - Allow regex renaming of unnamed devices #17212
Conversation
* Allow regex renaming of unnamed devices (already allowed actually) * Catch errors relating to unnamed devices or integrity errors as a result of the rename process
DanSheps
added
the
type: bug
jeremystretch
removed
the
type: bug
| except IntegrityError as e: | ||
| messages.error(self.request, ", ".join(e.args)) | ||
| clear_events.send(sender=self) | ||
|
|
||
| except ValidationError as e: | ||
| messages.error(self.request, ", ".join(e.messages)) | ||
| clear_events.send(sender=self) | ||
|
|
There was a problem hiding this comment.
Are these changes strictly relevant to #14044? If not, we should break them out into a separate bug report.
There was a problem hiding this comment.
They are. This will throw a validation error if we don't use regex (We can easily dump that though if we want to go to None == '')
The Integrity error will catch any associated integrity errors. I tried to fine a way to separate the integrity error out and only capture an integrity error that relates to the name field but it wasn't easily do-able.
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further action is taken. |
github-actions
bot
added
the
pending closure
DanSheps
removed
the
pending closure
|
AFAICT the only change actually needed to address #14044 is to ensure that a null name is always treated as an empty string. (Currently this is true only when regex is enabled.) Have I missed something? |
I can get that fixed up right away then |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further action is taken. |
github-actions
bot
added
the
pending closure
DanSheps
removed
the
pending closure
…into 14044-bulkrename-nameless-devices
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further action is taken. |
github-actions
bot
added
the
pending closure
DanSheps
removed
the
pending closure
Fixes: #14044 - Allow regex renaming of unnamed devices
Note: I removed the ^$ requirement as, in my view, as long as there is a valid regex and the regex results in a unique set, we don't need to enforce the ^$ requirement. For example:
^or.*or.would all be equally as valid.The main changes here catch both IntegrityError's from the DB and a validation error to ensure regex is used.