Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serial and console form factors #1748

Conversation

explody
Copy link
Contributor

@explody explody commented Dec 4, 2017

Fixes:

Addresses #167 though I could add a new issue if preferred

This PR adds two enhancements

  • 3 Additional form factors for serial network interfaces

    • DE9
    • DB25
    • RJ45
  • Adds form factor selection for console ports and console server ports as well as their related templates.

    • RJ45
    • DE9
    • DB25
    • USB to Serial
    • Micro USB to Serial
    • Mini USB to Serial
    • KVM

The rationale here is that even now, there are machines with call-home on landlines that use serial-to-modem for that connection. In particular, door access control systems and the like in our DCs and telco spaces often have old or unusual connections. The added serial types cover the most common.

For the console port form factors, it is because we determined that nearly every device we found has one or more console ports, but not all the same type or quantity of each. Specifying a FF for the console connections allows a user to more thoroughly plan interconnections between devices such as with network, without, IMHO, bogging down in too much detail.

I added the FF to the console port table, but I did not enable bulk editing since there's really only the one setting per port. Might make sense later if it were worthwhile to record baud rate or other serial settings.

@explody
Copy link
Contributor Author

explody commented Dec 4, 2017

Forgot the migration, I'll resubmit

@explody explody closed this Dec 4, 2017
@explody
Copy link
Contributor Author

explody commented Dec 4, 2017

Added forgotten migration as well as template fix to properly display console port FF on the device page.

@explody explody reopened this Dec 4, 2017
@jeremystretch
Copy link
Member

Thanks for taking a stab at this, but this requires a new feature request be opened for discussion before any PR can be accepted.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants