Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Addresses #167 though I could add a new issue if preferred
This PR adds two enhancements
3 Additional form factors for serial network interfaces
Adds form factor selection for console ports and console server ports as well as their related templates.
The rationale here is that even now, there are machines with call-home on landlines that use serial-to-modem for that connection. In particular, door access control systems and the like in our DCs and telco spaces often have old or unusual connections. The added serial types cover the most common.
For the console port form factors, it is because we determined that nearly every device we found has one or more console ports, but not all the same type or quantity of each. Specifying a FF for the console connections allows a user to more thoroughly plan interconnections between devices such as with network, without, IMHO, bogging down in too much detail.
I added the FF to the console port table, but I did not enable bulk editing since there's really only the one setting per port. Might make sense later if it were worthwhile to record baud rate or other serial settings.