Fixes #16024: Change attr_type from list to str for MultipleChoiceFilter
#17638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That does seem to fix the major issues, there are some issues with NOT handling, but I think that is potentially a separate issue. |
arthanson
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
I think go ahead with this. It is a work-around rather than a direct fix, but will fix it for this specific case as it bypasses using Django-filter and doesn't fix the underlying incompatibility between Strawberry and Django-filter. But this does fix a a larger part of the filtering and I couldn't find a drawback to going forward with this.
What this basically does is not go the Django-filter function to do the filtering, but just relies on Strawberry to do a char filter, which works as this is on the model and is char field.
bctiemann
pushed a commit
that referenced
this pull request
Oct 11, 2024
jeremystretch
added a commit
to alehaa/netbox
that referenced
this pull request
Oct 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16024
This seems to fix the AND/OR/NOT filtering specifically for multiple-choice filters. Additional work is likely needed but I wanted to put this out there for testing.