Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #17732 - Add a background-color to img elements in docs to ensure readability in dark mode #17790

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

bctiemann
Copy link
Contributor

Fixes: #17732

Adds a background-color property to the img CSS style for docs, to ensure that PNGs with transparent backgrounds and black text are still readable even on a dark-mode background.

Screenshot 2024-10-16 at 2 18 10 PM

@bctiemann bctiemann self-assigned this Oct 16, 2024
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logo on the main page still needs to be fixed:

screenshot

@bctiemann
Copy link
Contributor Author

Screenshot 2024-10-17 at 3 10 21 PM Screenshot 2024-10-17 at 3 10 26 PM

@bctiemann bctiemann force-pushed the 17732-png-background-color-develop branch from 761ae23 to eb27c5f Compare October 17, 2024 19:29
@jeremystretch
Copy link
Member

Unfortunately I don't think the white outline will comply with our branding rules for the logo. We do have dark & light versions of the logo available, and it looks like mkdocs-material does support image toggling for light & dark modes. I'll take a stab at it.

@bctiemann
Copy link
Contributor Author

Well that's better for sure.

@jeremystretch jeremystretch merged commit d8c5147 into develop Oct 18, 2024
@jeremystretch jeremystretch deleted the 17732-png-background-color-develop branch October 18, 2024 14:47
LeoColomb added a commit to netbox-community/netbox-chart that referenced this pull request Oct 20, 2024
Fix logo

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diagram in Upgrade Instructions is Not Readable
2 participants