Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #13428: Q-in-Q VLANs #17822

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Closes #13428: Q-in-Q VLANs #17822

merged 4 commits into from
Oct 31, 2024

Conversation

jeremystretch
Copy link
Member

@jeremystretch jeremystretch commented Oct 21, 2024 •
edited
Loading

Closes: #13428

  • Add Q-in-Q to InterfaceModeChoices
  • Move untagged_vlan & tagged_vlans model fields to BaseInterface
  • Add qinq_svlan field to BaseInterface
  • Add qinq_role & qinq_svlan fields to VLAN

@jeremystretch jeremystretch mentioned this pull request Oct 21, 2024
Closed
@jeremystretch jeremystretch added this to the v4.2 milestone Oct 22, 2024
@jeremystretch jeremystretch marked this pull request as ready for review October 28, 2024 16:27
arthanson
arthanson requested changes Oct 30, 2024
View reviewed changes
netbox/dcim/models/device_components.py Outdated Show resolved Hide resolved
netbox/dcim/tests/test_filtersets.py Outdated Show resolved Hide resolved
netbox/dcim/models/device_components.py Show resolved Hide resolved
netbox/ipam/graphql/types.py Show resolved Hide resolved
netbox/ipam/models/vlans.py Show resolved Hide resolved
netbox/ipam/models/vlans.py Show resolved Hide resolved
@jeremystretch jeremystretch merged commit 8767fd8 into feature Oct 31, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 13428-qinq branch October 31, 2024 18:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arthanson arthanson arthanson requested changes

@bctiemann bctiemann bctiemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremystretch @arthanson @bctiemann