-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes: #17923, #17921 - Fix non-null constraint for script execution #17932
Fixes: #17923, #17921 - Fix non-null constraint for script execution #17932
Conversation
With c34a0e2, validation of job object fields is enabled, so ScriptJob must not set required fields to empty strings. This commit reverts b18f193 and (hopefully) fixes this issue not only for UI views, but for all interactions with scripts. Fixes: netbox-community#17923
The proposed fix will set I believe a more effective solution would be next:
|
For recurring jobs, the name must be passed to the next job object when the job is rescheduled.
IMO naming the job "run script" is acceptable, because that's what it's doing, and each job retains a relation to its corresponding script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes: #17921
With c34a0e2, validation of job object fields is enabled, so ScriptJob must not set required fields to empty strings. Changes of this PR revert b18f193 and (hopefully) fix this issue not only for UI views, but for all interactions with scripts.