Fixes 18183 - Hide Light/Dark Mode and Login Info from Printed Pages #18185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeremystretch - would you prefer no logo or logo? Also I'm not a CSS wizard but I can add classes.... Adding to aside:
Adding to User menu (mobile view) div:
|
|
IMO it makes sense to omit the entire top bar when printing ( |
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18183
This will add the
d-print-noneto the mobile view so objects being printed out will suppress the Light/Dark Mode and Login Info. Looking at the template, it was intended to suppress these details, but Chrome and Firefox are triggering in the mobile view for printing. I tested on both Chrome (131.0.6778.109 (Official Build) (64-bit)) and Firefox (128.5.1esr (64-bit)).Pre-Change:
Post Change: