Fixes: #17868 - Handle orphaned cable condition gracefully in SVG rendering #18244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o draw_far_objects (e.g. orphaned cable where attached device has been deleted)
jeremystretch
requested changes
Dec 17, 2024
Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>
jeremystretch
approved these changes
Dec 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17868
If a device has been deleted, attached cables may be left orphaned, which leads to rendering errors when generating the cable trace SVG. This fix handles the case where the object list passed in to
draw_far_objectsis empty by returning empty lists of results and then handling those gracefully so that the remaining portion of the SVG can be rendered.