Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes: #18369 - Remove the json filter for protection rules #18388

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Fixes: #18369 - Remove the json filter for protection rules #18388

merged 3 commits into from
Jan 17, 2025

Conversation

atownson
Copy link
Contributor

Fixes: #18369

Removing the json filter resolves the TypeError exception and aligns the protection rules template with the custom validators template.

jeremystretch
jeremystretch requested changes Jan 17, 2025
View reviewed changes
netbox/core/views.py Outdated Show resolved Hide resolved
jeremystretch
jeremystretch approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @atownson!

@jeremystretch jeremystretch merged commit 2ed4a2b into netbox-community:main Jan 17, 2025
3 checks passed
bctiemann pushed a commit that referenced this pull request Jan 28, 2025
@atownson @jeremystretch @bctiemann
Fixes: #18369 - Remove the json filter for protection rules (#18388)
92b0e44 
* Remove the json filter for protection rules

* Configure PROTECTION_RULE config attribute to use ConfigJSONEncoder as serializer

* Tweak getattr()

---------

Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>
bctiemann pushed a commit that referenced this pull request Jan 29, 2025
@atownson @jeremystretch @bctiemann
Fixes: #18369 - Remove the json filter for protection rules (#18388)
39cd8bc 
* Remove the json filter for protection rules

* Configure PROTECTION_RULE config attribute to use ConfigJSONEncoder as serializer

* Tweak getattr()

---------

Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremystretch jeremystretch jeremystretch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON serializer issue for Protection Rules defined in configuration.py
2 participants
@atownson @jeremystretch