RFC: Fixes #20290: Prevent ObjectType queries when table doesn't exist #20473
+28
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20290
In v4.4.0,
ObjectType
became a concrete model with a database table. Signal handlers query this table during migrations, but the table doesn't exist yet during 3.7.x→4.4.0 upgrades. The query failures poison the transaction and abort migrations.This commits adds a
objecttype_table_exists()
helper and and uses it in three places:has_feature()
in netbox/models/features.pyupdate_object_types()
in core/signals.pySearch backend cache()
in search/backends.pyIf
core_objecttype
table doesn't exist, operations return early instead of querying. Once table exists, normal operation resumes.Pros
Cons
ObjectType
during migrations could still fail/future developers might not know to add this check in new codehas_feature()
call