Fixes #20471: Update NumericRange handling to use half-open intervals #20478
+18
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes NumericRange boundaries to use half-open intervals [lower, upper). Updates logic in data utilities, and corresponding tests to reflect this standard. Ensures consistency across range handling and validation outputs. Fixes netbox-community#20471
pheus
force-pushed
the
20471-update-numericrange-handling-using-half-open-intervals
branch
from
33148f3 to
3a755ee
Compare
jnovinger
requested review from
a team and
arthanson
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20471
Summary
Normalize integer range handling to use half‑open intervals
[lower, upper)across the app. Inclusive inputs are still accepted (forms/CSV/API) but are converted to a canonical half‑open form on save and serialization. This yields stable pre/post snapshots and prevents spurious change log entries when saving an unchangedVLANGroup.Changes
NumericRangevalues forVLANGroup.vid_rangesto[lo, hi)in forms, serializers, and utilities.Notes