Fixes #20475: Collapse singleton VLAN IDs in VLANGroup display #20479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
jeremystretch
requested review from
a team and
arthanson
and removed request for
a team
Updates the `ranges_to_string` function to handle single-value ranges and improve string representation. Refines the formatting logic to include isolated values when the lower and upper bounds of a range are identical. Fixes netbox-community#20475
pheus
force-pushed
the
20475-vlangroup-collapse-singletons
branch
from
dc92fb2 to
f5b8077
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20475
Summary
Collapse singleton VLAN ID ranges when rendering/storing display strings.
Input
1-5,10,20-30remains1-5,10,20-30instead of1-5,10-10,20-30.Implementation
Update
utilities.ranges_to_string()to emit a bare integer whenstart == end.Before → After
1-5,10-10,20-30→1-5,10,20-30