Fixes #20646: Prevent cables from connecting to marked_connected objects
#20678
+26
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restricts cable connections to terminations flagged as "mark connected" to avoid logical conflicts. Adds validation in the `Cable.clean()` method and includes corresponding test cases to verify behavior. Fixes netbox-community#20646
jnovinger
requested review from
a team and
jnovinger
and removed request for
a team
jnovinger
approved these changes
Oct 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20646
Restricts creating cable terminations for endpoints flagged as "mark connected" to avoid the invalid state of being both virtually connected and physically cabled. The validation is implemented in
dcim.CableTermination.clean(), ensuring consistent behavior across the UI, REST API, and CSV import. Includes a test covering the rejection case.Summary of Changes
CableTermination.clean()to raiseValidationErrorwhentermination.mark_connected == True.mark_connected(e.g., interfaces, power/power-feed ports, front/rear ports, circuit terminations).mark_connected