Fixes #20134: Prevent HTMX OOB swaps in embedded tables #20811
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The htmx/table.html template was unconditionally including out-of-band (OOB) swaps for UI elements that only exist on list pages, causing htmx:oobErrorNoTarget errors when tables were embedded on detail pages. This change adds checks for table.embedded to conditionally exclude OOB swaps for .total-object-count, #table_save_link, and .bulk-action-buttons when rendering embedded tables via the htmx_table template tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20134
The
htmx/table.htmltemplate was unconditionally including out-of-band (OOB) swaps for UI elements that only exist on list pages, causinghtmx:oobErrorNoTargeterrors when tables were embedded on detail pages.This change adds checks for
table.embeddedto conditionally exclude OOB swaps for.total-object-count,#table_save_link, and.bulk-action-buttonswhen rendering embedded tables.