Updated IPAddressInterfaceSerializer to subclass WritableNestedSerial… #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…izer Also added readonly args to device and virtual_machine attrs to prevent unnecessary validation
| url = serializers.SerializerMethodField() # We're imitating a HyperlinkedIdentityField here | ||
| device = NestedDeviceSerializer() | ||
| virtual_machine = NestedVirtualMachineSerializer() | ||
| device = NestedDeviceSerializer(read_only=True) |
There was a problem hiding this comment.
This serializer is used for write (POST/PATCH) operations. These fields can't be read-only.
Nevermind, ignore me.
|
Tests are failing for an unrelated reason. Tried the changes locally and they work. 👍 |
This was referenced Aug 3, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…izer
Also added readonly args to device and virtual_machine attrs to prevent unnecessary validation
Fixes:
#2299
Per @jeremystretch recommendation, I changed IPAddressInterfaceSerializer to subclass the more modern WritableNestedSerializer. Considering WritableNestedSerializer takes only a PK for write ops, and because nested attrs for device and virtual_machine were still throwing validation errors after changing the parent class, I added
read_only=Trueargs to both. This fixed the validation and I confirmed that I could alternately PATCH an address with interface values of NULL or a PK successfully.